summaryrefslogtreecommitdiffstats
path: root/nixos/tests/systemd-boot.nix
blob: 93e58b8eabf25367a8c9342b4fa79297bf5ff23e (plain)
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
697
698
699
700
701
702
703
704
705
706
707
708
709
710
711
712
713
714
715
716
717
718
719
720
721
722
723
724
725
726
727
728
729
730
731
732
733
734
735
736
737
738
739
740
741
742
743
744
745
746
747
748
749
750
751
752
753
754
755
756
757
758
759
760
761
762
763
764
765
766
767
768
769
770
771
772
773
774
775
776
777
778
779
780
781
782
783
784
785
786
787
788
789
790
791
792
793
794
795
796
797
798
799
800
801
802
803
804
805
806
807
808
809
810
811
812
813
814
815
816
817
818
819
820
821
822
823
824
825
826
827
828
829
830
831
832
833
834
835
836
837
838
839
840
841
842
843
844
845
846
847
848
849
850
851
852
853
854
855
856
857
858
859
860
861
862
863
864
865
866
867
868
869
870
871
872
873
874
875
876
877
878
879
880
881
882
883
884
885
886
887
888
889
890
891
892
893
894
895
896
897
898
899
900
901
902
903
904
905
906
907
908
909
910
911
912
913
914
915
916
917
918
919
920
921
922
923
924
925
926
927
928
929
930
931
932
933
934
935
936
937
938
939
940
941
942
943
944
945
946
947
948
949
{
  runTest,
  runTestOn,
  lib,
}:

let
  testScriptPreamble =
    # python
    ''
      def check_current_system(system_path):
          machine.succeed(f'test $(readlink -f /run/current-system) = "{system_path}"')

      def check_generation(generation: int, tries_left=0, tries_failed=0, specialisation=None) -> list[str]:
          if specialisation:
              title = f"NixOS ({specialisation})"
          else:
              title = "NixOS"

          conf_files = machine.succeed(
              f"grep --files-with-matches 'version Generation {generation} NixOS' /boot/loader/entries/nixos-*.conf | xargs grep --line-regexp --fixed-strings --files-with-matches 'title {title}'"
          ).split("\n")

          suffix = ""
          if tries_left:
              suffix += f"+{tries_left}"
          if tries_failed:
              suffix += f"-{tries_failed}"

          assert conf_files[0].endswith(f"{suffix}.conf"), f"Expected {conf_files[0]} to end with {suffix}.conf"
          return conf_files
    '';

  common =
    { pkgs, ... }:
    {
      virtualisation.useBootLoader = true;
      virtualisation.useEFIBoot = true;
      boot.loader.systemd-boot.enable = true;
      boot.loader.efi.canTouchEfiVariables = true;
      environment.systemPackages = [ pkgs.efibootmgr ];
      system.switch.enable = true;
      nix.enable = true; # disabled by default. See all-tests.nix / tag(no-nix-by-default)

      # Needed for machine-id to be persisted between reboots.
      # Must be a valid (non-zero) ID, otherwise sd_id128_get_machine()
      # returns -ENOMEDIUM and dbus-broker refuses to start.
      environment.etc."machine-id".text = "1234567890abcdef1234567890abcdef\n";
    };

  commonXbootldr =
    {
      config,
      lib,
      pkgs,
      ...
    }:
    let
      diskImage = import ../lib/make-disk-image.nix {
        inherit config lib pkgs;
        label = "nixos";
        format = "qcow2";
        partitionTableType = "efixbootldr";
        touchEFIVars = true;
        installBootLoader = true;
        # Don't copy the channel to avoid rebuilding this image, and all tests
        # that use it, every time that nixpkgs changes
        copyChannel = false;
      };
    in
    {
      imports = [ common ];
      virtualisation.useBootLoader = lib.mkForce false; # Only way to tell qemu-vm not to create the default system image
      virtualisation.directBoot.enable = false; # But don't direct boot either because we're testing systemd-boot

      system.build.diskImage = diskImage; # Use custom disk image with an XBOOTLDR partition
      virtualisation.efi.variables = "${diskImage}/efi-vars.fd";

      virtualisation.useDefaultFilesystems = false; # Needs custom setup for `diskImage`
      virtualisation.bootPartition = null;
      virtualisation.fileSystems = {
        "/" = {
          device = "/dev/vda3";
          fsType = "ext4";
        };
        "/boot" = {
          device = "/dev/vda2";
          fsType = "vfat";
          noCheck = true;
        };
        "/efi" = {
          device = "/dev/vda1";
          fsType = "vfat";
          noCheck = true;
        };
      };

      boot.loader.systemd-boot.enable = true;
      boot.loader.efi.efiSysMountPoint = "/efi";
      boot.loader.systemd-boot.xbootldrMountPoint = "/boot";
    };

  customDiskImage =
    nodes:
    # python
    ''
      import os
      import subprocess
      import tempfile

      tmp_disk_image = tempfile.NamedTemporaryFile()

      subprocess.run([
        "${nodes.machine.virtualisation.qemu.package}/bin/qemu-img",
        "create",
        "-f",
        "qcow2",
        "-b",
        "${nodes.machine.system.build.diskImage}/nixos.qcow2",
        "-F",
        "qcow2",
        tmp_disk_image.name,
      ])

      # Set NIX_DISK_IMAGE so that the qemu script finds the right disk image.
      os.environ['NIX_DISK_IMAGE'] = tmp_disk_image.name
    '';

  # Check that we are booting the default entry and not the generation with largest version number
  defaultEntry =
    {
      withBootCounting ? false,
      ...
    }:
    runTest {
      name = "systemd-boot-default-entry" + lib.optionalString withBootCounting "-with-boot-counting";
      meta.maintainers = with lib.maintainers; [ julienmalka ];

      nodes = {
        machine =
          { nodes, ... }:
          {
            imports = [ common ];
            system.extraDependencies = [ nodes.other_machine.system.build.toplevel ];
            boot.loader.systemd-boot.bootCounting.enable = withBootCounting;
          };

        other_machine =
          { pkgs, ... }:
          {
            imports = [ common ];
            boot.loader.systemd-boot.bootCounting.enable = withBootCounting;
            environment.systemPackages = [ pkgs.hello ];
          };
      };
      testScript =
        { nodes, ... }:
        let
          orig = nodes.machine.system.build.toplevel;
          other = nodes.other_machine.system.build.toplevel;
        in
        # python
        ''
          ${testScriptPreamble}

          orig = "${orig}"
          other = "${other}"

          check_current_system(orig)

          # Switch to other configuration
          machine.succeed("nix-env -p /nix/var/nix/profiles/system --set ${other}")
          machine.succeed(f"{other}/bin/switch-to-configuration boot")
          # Rollback, default entry is now generation 1
          machine.succeed("nix-env -p /nix/var/nix/profiles/system --rollback")
          machine.succeed(f"{orig}/bin/switch-to-configuration boot")
          machine.shutdown()
          machine.start()
          machine.wait_for_unit("multi-user.target")
          # Check that we booted generation 1 (default)
          # even though generation 2 comes first in alphabetical order
          check_current_system(orig)
        '';
    };

  garbage-collect-entry =
    {
      withBootCounting ? false,
      ...
    }:
    runTest (
      { lib, ... }:
      {
        name =
          "systemd-boot-garbage-collect-entry" + lib.optionalString withBootCounting "-with-boot-counting";
        meta.maintainers = with lib.maintainers; [ julienmalka ];

        nodes = {
          inherit common;
          machine =
            { nodes, ... }:
            {
              imports = [ common ];

              boot.loader.systemd-boot.bootCounting.enable = withBootCounting;
              boot.loader.systemd-boot.memtest86.enable = true;

              # These are configs for different nodes, but we'll use them here in `machine`
              system.extraDependencies = [
                nodes.common.system.build.toplevel
              ];
            };
        };

        testScript =
          { nodes, ... }:
          let
            baseSystem = nodes.common.system.build.toplevel;
          in
          # python
          ''
            ${testScriptPreamble}

            machine.succeed("nix-env -p /nix/var/nix/profiles/system --set ${baseSystem}")
            machine.succeed("nix-env -p /nix/var/nix/profiles/system --delete-generations 1")

            conf_file = check_generation(1)[0]
            new_conf_file = conf_file.replace(".conf", "+1-3.conf")

            # At this point generation 1 has already been marked as good so we reintroduce counters artificially
            ${lib.optionalString withBootCounting ''
              machine.succeed(f"mv {conf_file} {new_conf_file}")
            ''}
            machine.succeed("${baseSystem}/bin/switch-to-configuration boot")
            machine.fail(
              "grep --files-with-matches 'version Generation 1 NixOS' /boot/loader/entries/nixos-*.conf"
            )
            check_generation(2)
          '';
      }
    );
in
{
  defaultEntry = defaultEntry { };
  garbage-collect-entry = garbage-collect-entry { };

  basic = runTest (
    { lib, ... }:
    {
      name = "systemd-boot";
      meta.maintainers = with lib.maintainers; [
        danielfullmer
        julienmalka
      ];

      nodes.machine = common;

      testScript = # python
        ''
          ${testScriptPreamble}

          machine.start()
          machine.wait_for_unit("multi-user.target")

          conf_file = check_generation(1)[0]

          machine.succeed(f"grep 'sort-key nixos' {conf_file}")

          # Ensure we actually booted using systemd-boot
          # Magic number is the vendor UUID used by systemd-boot.
          machine.succeed(
              "test -e /sys/firmware/efi/efivars/LoaderEntrySelected-4a67b082-0a4c-41cf-b6c7-440b29bb8c4f"
          )

          # "bootctl install" should have created an EFI entry
          machine.succeed('efibootmgr | grep "Linux Boot Manager"')
        '';
    }
  );

  # Test that systemd-boot works with secure boot
  secureBoot = runTest (
    { pkgs, lib, ... }:
    {
      name = "systemd-boot-secure-boot";

      nodes.machine =
        { pkgs, ... }:
        {
          imports = [ common ];
          environment.systemPackages = [ pkgs.sbctl ];
        };

      testScript =
        { nodes, ... }:
        let
          efiArch = pkgs.stdenv.hostPlatform.efiArch;
        in
        #python
        ''
          machine.start(allow_reboot=True)
          machine.wait_for_unit("multi-user.target")

          machine.succeed("sbctl create-keys")
          machine.succeed("sbctl enroll-keys --yes-this-might-brick-my-machine")
          machine.succeed('sbctl sign /boot/EFI/systemd/systemd-boot${efiArch}.efi')
          machine.succeed('sbctl sign /boot/EFI/BOOT/BOOT${lib.toUpper efiArch}.EFI')
          machine.succeed('sbctl sign /boot/EFI/nixos/*${nodes.machine.system.boot.loader.kernelFile}.efi')

          machine.reboot()

          assert "Secure Boot: enabled (user)" in machine.succeed("bootctl status")
        '';
    }
  );

  # TODO: Fix on aarch64-linux
  basicXbootldr = runTestOn [ "x86_64-linux" ] (
    { lib, ... }:
    {
      name = "systemd-boot-xbootldr";
      meta.maintainers = with lib.maintainers; [ sdht0 ];

      nodes.machine = commonXbootldr;

      testScript =
        { nodes, ... }:
        #python
        ''
          ${testScriptPreamble}

          ${customDiskImage nodes}

          machine.start()
          machine.wait_for_unit("multi-user.target")

          machine.succeed("test -e /efi/EFI/systemd/systemd-bootx64.efi")
          check_generation(1)

          # Ensure we actually booted using systemd-boot
          # Magic number is the vendor UUID used by systemd-boot.
          machine.succeed(
              "test -e /sys/firmware/efi/efivars/LoaderEntrySelected-4a67b082-0a4c-41cf-b6c7-440b29bb8c4f"
          )

          # "bootctl install" should have created an EFI entry
          machine.succeed('efibootmgr | grep "Linux Boot Manager"')
        '';
    }
  );

  # Check that specialisations create corresponding boot entries.
  specialisation = runTest (
    { pkgs, lib, ... }:
    {
      name = "systemd-boot-specialisation";
      meta.maintainers = with lib.maintainers; [
        lukegb
        julienmalka
      ];

      nodes.machine =
        { pkgs, lib, ... }:
        {
          imports = [ common ];
          specialisation.something.configuration = {
            boot.loader.systemd-boot.sortKey = "something";

            # Since qemu will dynamically create a devicetree blob when starting
            # up, it is not straight forward to create an export of that devicetree
            # blob without knowing before-hand all the flags we would pass to qemu
            # (we would then be able to use `dumpdtb`). Thus, the following config
            # will not boot, but it does allow us to assert that the boot entry has
            # the correct contents.
            boot.loader.systemd-boot.installDeviceTree = pkgs.stdenv.hostPlatform.isAarch64;
            hardware.deviceTree.name = "dummy.dtb";
            hardware.deviceTree.package = lib.mkForce (
              pkgs.runCommand "dummy-devicetree-package" { } ''
                mkdir -p $out
                cp ${pkgs.emptyFile} $out/dummy.dtb
              ''
            );
          };
        };

      testScript =
        # python
        ''
          ${testScriptPreamble}

          machine.start()
          machine.wait_for_unit("multi-user.target")

          conf_files = check_generation(1, specialisation="something")
          machine.succeed(
              f"grep --fixed-strings --line-regexp 'sort-key something' {" ".join(conf_files)}"
          )

          ${lib.optionalString pkgs.stdenv.hostPlatform.isAarch64
            #python
            ''
              machine.succeed(
                  fr"grep 'devicetree /EFI/nixos/[a-z0-9]\{32\}.*dummy' {" ".join(conf_files)}"
              )
            ''
          }
        '';
    }
  );

  # Boot without having created an EFI entry--instead using default "/EFI/BOOT/BOOTX64.EFI"
  fallback = runTest (
    { lib, ... }:
    {
      name = "systemd-boot-fallback";
      meta.maintainers = with lib.maintainers; [
        danielfullmer
        julienmalka
      ];

      nodes.machine =
        { lib, ... }:
        {
          imports = [ common ];
          boot.loader.efi.canTouchEfiVariables = lib.mkForce false;
        };

      testScript =
        # python
        ''
          ${testScriptPreamble}

          machine.start()
          machine.wait_for_unit("multi-user.target")

          check_generation(1)

          # Ensure we actually booted using systemd-boot
          # Magic number is the vendor UUID used by systemd-boot.
          machine.succeed(
              "test -e /sys/firmware/efi/efivars/LoaderEntrySelected-4a67b082-0a4c-41cf-b6c7-440b29bb8c4f"
          )

          # "bootctl install" should _not_ have created an EFI entry
          machine.fail('efibootmgr | grep "Linux Boot Manager"')
        '';
    }
  );

  # TODO: Fix on aarch64-linux
  update = runTestOn [ "x86_64-linux" ] (
    { lib, ... }:
    {
      name = "systemd-boot-update";
      meta.maintainers = with lib.maintainers; [
        danielfullmer
        julienmalka
      ];

      nodes.machine = common;

      testScript =
        # python
        ''
          machine.succeed("mount -o remount,rw /boot")

          def switch():
              # Replace version inside sd-boot with something older. See SD_MAGIC in systemd src/boot/boot.c
              # Note: the sed replacement has to be length-preserving, because section length matters.
              machine.succeed(
                r"""
                find /boot -iname '*boot*.efi' -print0 | \
                xargs -0 -I '{}' sed -i 's/#### LoaderInfo: systemd-boot [0-9]\(.*\) ####/#### LoaderInfo: systemd-boot 0\1 ####/' '{}'
                """
              )
              return machine.succeed("/run/current-system/bin/switch-to-configuration boot 2>&1")

          output = switch()
          assert 'to "/boot/EFI/systemd/systemd-bootx64.efi"' in output, "systemd-boot not copied to to /boot/EFI/systemd/systemd-bootx64.efi"
          assert 'to "/boot/EFI/BOOT/BOOTX64.EFI"' in output, "systemd-boot not copied to to /boot/EFI/BOOT/BOOTX64.EFI"

          with subtest("Test that updating works with lowercase bootx64.efi"):
              machine.succeed(
                  # Move to tmp file name first, otherwise mv complains the new location is the same
                  "mv /boot/EFI/BOOT/BOOTX64.EFI /boot/EFI/BOOT/bootx64.efi.new",
                  "mv /boot/EFI/BOOT/bootx64.efi.new /boot/EFI/BOOT/bootx64.efi",
              )
              output = switch()
              assert 'to "/boot/EFI/systemd/systemd-bootx64.efi"' in output, "systemd-boot not copied to to /boot/EFI/systemd/systemd-bootx64.efi"
              assert 'to "/boot/EFI/BOOT/BOOTX64.EFI"' in output, "systemd-boot not copied to to /boot/EFI/BOOT/BOOTX64.EFI"

          with subtest("Test that switching with an up-to-date bootloader is a no-op"):
              output = machine.succeed("/run/current-system/bin/switch-to-configuration boot 2>&1")
              assert "same boot loader version in place already" in output, "Expected bootctl to skip already-current binary"
        '';
    }
  );

  memtest86 = runTestOn [ "x86_64-linux" ] (
    { lib, ... }:
    {
      name = "systemd-boot-memtest86";
      meta.maintainers = with lib.maintainers; [ julienmalka ];

      nodes.machine = {
        imports = [ common ];
        boot.loader.systemd-boot.memtest86.enable = true;
      };

      testScript =
        # python
        ''
          machine.succeed("test -e /boot/loader/entries/memtest86.conf")
          machine.succeed("test -e /boot/efi/memtest86/memtest.efi")
        '';
    }
  );

  netbootxyz = runTest (
    { lib, ... }:
    {
      name = "systemd-boot-netbootxyz";
      meta.maintainers = with lib.maintainers; [ julienmalka ];

      nodes.machine = {
        imports = [ common ];
        boot.loader.systemd-boot.netbootxyz.enable = true;
      };

      testScript =
        # python
        ''
          machine.succeed("test -e /boot/loader/entries/netbootxyz.conf")
          machine.succeed("test -e /boot/efi/netbootxyz/netboot.xyz.efi")
        '';
    }
  );

  edk2-uefi-shell = runTest (
    { lib, ... }:
    {
      name = "systemd-boot-edk2-uefi-shell";
      meta.maintainers = with lib.maintainers; [ iFreilicht ];

      nodes.machine =
        { ... }:
        {
          imports = [ common ];
          boot.loader.systemd-boot.edk2-uefi-shell.enable = true;
        };

      testScript =
        # python
        ''
          machine.succeed("test -e /boot/loader/entries/edk2-uefi-shell.conf")
          machine.succeed("test -e /boot/efi/edk2-uefi-shell/shell.efi")
        '';
    }
  );

  windows = runTest (
    { lib, ... }:
    {
      name = "systemd-boot-windows";
      meta.maintainers = with lib.maintainers; [ iFreilicht ];

      nodes.machine =
        { ... }:
        {
          imports = [ common ];
          boot.loader.systemd-boot.windows = {
            "7" = {
              efiDeviceHandle = "HD0c1";
              sortKey = "before_all_others";
            };
            "Ten".efiDeviceHandle = "FS0";
            "11" = {
              title = "Title with-_-punctuation ...?!";
              efiDeviceHandle = "HD0d4";
              sortKey = "zzz";
            };
          };
        };

      testScript =
        # python
        ''
          machine.succeed("test -e /boot/efi/edk2-uefi-shell/shell.efi")

          machine.succeed("test -e /boot/loader/entries/windows_7.conf")
          machine.succeed("test -e /boot/loader/entries/windows_Ten.conf")
          machine.succeed("test -e /boot/loader/entries/windows_11.conf")

          machine.succeed("grep 'efi /efi/edk2-uefi-shell/shell.efi' /boot/loader/entries/windows_7.conf")
          machine.succeed("grep 'efi /efi/edk2-uefi-shell/shell.efi' /boot/loader/entries/windows_Ten.conf")
          machine.succeed("grep 'efi /efi/edk2-uefi-shell/shell.efi' /boot/loader/entries/windows_11.conf")

          machine.succeed("grep 'HD0c1:EFI\\\\Microsoft\\\\Boot\\\\Bootmgfw.efi' /boot/loader/entries/windows_7.conf")
          machine.succeed("grep 'FS0:EFI\\\\Microsoft\\\\Boot\\\\Bootmgfw.efi' /boot/loader/entries/windows_Ten.conf")
          machine.succeed("grep 'HD0d4:EFI\\\\Microsoft\\\\Boot\\\\Bootmgfw.efi' /boot/loader/entries/windows_11.conf")

          machine.succeed("grep 'sort-key before_all_others' /boot/loader/entries/windows_7.conf")
          machine.succeed("grep 'sort-key o_windows_Ten' /boot/loader/entries/windows_Ten.conf")
          machine.succeed("grep 'sort-key zzz' /boot/loader/entries/windows_11.conf")

          machine.succeed("grep 'title Windows 7' /boot/loader/entries/windows_7.conf")
          machine.succeed("grep 'title Windows Ten' /boot/loader/entries/windows_Ten.conf")
          machine.succeed('grep "title Title with-_-punctuation ...?!" /boot/loader/entries/windows_11.conf')
        '';
    }
  );

  memtestSortKey = runTest (
    { lib, ... }:
    {
      name = "systemd-boot-memtest-sortkey";
      meta.maintainers = with lib.maintainers; [ julienmalka ];

      nodes.machine = {
        imports = [ common ];
        boot.loader.systemd-boot.memtest86.enable = true;
        boot.loader.systemd-boot.memtest86.sortKey = "apple";
      };

      testScript =
        # python
        ''
          machine.succeed("test -e /boot/loader/entries/memtest86.conf")
          machine.succeed("test -e /boot/efi/memtest86/memtest.efi")
          machine.succeed("grep 'sort-key apple' /boot/loader/entries/memtest86.conf")
        '';
    }
  );

  # TODO: Fix on aarch64-linux
  entryFilenameXbootldr = runTestOn [ "x86_64-linux" ] (
    { lib, ... }:
    {
      name = "systemd-boot-entry-filename-xbootldr";
      meta.maintainers = with lib.maintainers; [ sdht0 ];

      nodes.machine = {
        imports = [ commonXbootldr ];
        boot.loader.systemd-boot.memtest86.enable = true;
      };

      testScript =
        { nodes, ... }:
        # python
        ''
          ${customDiskImage nodes}

          machine.start()
          machine.wait_for_unit("multi-user.target")

          machine.succeed("test -e /efi/EFI/systemd/systemd-bootx64.efi")
          machine.succeed("test -e /boot/loader/entries/memtest86.conf")
          machine.succeed("test -e /boot/EFI/memtest86/memtest.efi")
        '';
    }
  );

  extraEntries = runTest (
    { lib, ... }:
    {
      name = "systemd-boot-extra-entries";
      meta.maintainers = with lib.maintainers; [ julienmalka ];

      nodes.machine = {
        imports = [ common ];
        boot.loader.systemd-boot.extraEntries = {
          "banana.conf" = ''
            title banana
          '';
        };
      };

      testScript =
        # python
        ''
          machine.succeed("test -e /boot/loader/entries/banana.conf")
          machine.succeed("test -e /boot/efi/nixos/.extra-files/loader/entries/banana.conf")
        '';
    }
  );

  extraFiles = runTest (
    { lib, ... }:
    {
      name = "systemd-boot-extra-files";
      meta.maintainers = with lib.maintainers; [ julienmalka ];

      nodes.machine =
        { pkgs, ... }:
        {
          imports = [ common ];
          boot.loader.systemd-boot.extraFiles = {
            "efi/fruits/tomato.efi" = pkgs.netbootxyz-efi;
          };
        };

      testScript =
        # python
        ''
          machine.succeed("test -e /boot/efi/fruits/tomato.efi")
          machine.succeed("test -e /boot/efi/nixos/.extra-files/efi/fruits/tomato.efi")
        '';
    }
  );

  switch-test = runTest (
    { lib, ... }:
    {
      name = "systemd-boot-switch-test";
      meta.maintainers = with lib.maintainers; [ julienmalka ];

      nodes = {
        inherit common;

        machine =
          { pkgs, nodes, ... }:
          {
            imports = [ common ];
            boot.loader.systemd-boot.extraFiles = {
              "efi/fruits/tomato.efi" = pkgs.netbootxyz-efi;
            };

            # These are configs for different nodes, but we'll use them here in `machine`
            system.extraDependencies = [
              nodes.common.system.build.toplevel
              nodes.with_netbootxyz.system.build.toplevel
            ];
          };

        with_netbootxyz = {
          imports = [ common ];
          boot.loader.systemd-boot.netbootxyz.enable = true;
        };
      };

      testScript =
        { nodes, ... }:
        let
          originalSystem = nodes.machine.system.build.toplevel;
          baseSystem = nodes.common.system.build.toplevel;
          finalSystem = nodes.with_netbootxyz.system.build.toplevel;
        in
        # python
        ''
          machine.succeed("test -e /boot/efi/fruits/tomato.efi")
          machine.succeed("test -e /boot/efi/nixos/.extra-files/efi/fruits/tomato.efi")

          with subtest("remove files when no longer needed"):
              machine.succeed("${baseSystem}/bin/switch-to-configuration boot")
              machine.fail("test -e /boot/efi/fruits/tomato.efi")
              machine.fail("test -d /boot/efi/fruits")
              machine.succeed("test -d /boot/efi/nixos/.extra-files")
              machine.fail("test -e /boot/efi/nixos/.extra-files/efi/fruits/tomato.efi")
              machine.fail("test -d /boot/efi/nixos/.extra-files/efi/fruits")

          with subtest("files are added back when needed again"):
              machine.succeed("${originalSystem}/bin/switch-to-configuration boot")
              machine.succeed("test -e /boot/efi/fruits/tomato.efi")
              machine.succeed("test -e /boot/efi/nixos/.extra-files/efi/fruits/tomato.efi")

          with subtest("simultaneously removing and adding files works"):
              machine.succeed("${finalSystem}/bin/switch-to-configuration boot")
              machine.fail("test -e /boot/efi/fruits/tomato.efi")
              machine.fail("test -e /boot/efi/nixos/.extra-files/efi/fruits/tomato.efi")
              machine.succeed("test -e /boot/loader/entries/netbootxyz.conf")
              machine.succeed("test -e /boot/efi/netbootxyz/netboot.xyz.efi")
              machine.succeed("test -e /boot/efi/nixos/.extra-files/loader/entries/netbootxyz.conf")
              machine.succeed("test -e /boot/efi/nixos/.extra-files/efi/netbootxyz/netboot.xyz.efi")
        '';
    }
  );

  bootCounting =
    let
      baseConfig = {
        imports = [ common ];

        boot.loader.systemd-boot.bootCounting = {
          enable = true;
          tries = 2;
        };
      };
    in
    runTest {
      name = "systemd-boot-counting";
      meta.maintainers = with lib.maintainers; [ julienmalka ];

      nodes = {
        machine =
          { nodes, ... }:
          {
            imports = [ baseConfig ];
            system.extraDependencies = [
              nodes.bad_machine.system.build.toplevel
              nodes.unused_machine.system.build.toplevel
            ];
          };

        unused_machine =
          { pkgs, ... }:
          {
            imports = [ baseConfig ];
            # Distinguish this closure from `machine` without pulling in extra deps.
            environment.systemPackages = [ pkgs.hello ];
          };

        bad_machine = {
          imports = [ baseConfig ];

          systemd.services."failing" = {
            script = "exit 1";
            requiredBy = [ "boot-complete.target" ];
            before = [ "boot-complete.target" ];
            serviceConfig.Type = "oneshot";
          };
        };
      };
      testScript =
        { nodes, ... }:
        let
          orig = nodes.machine.system.build.toplevel;
          bad = nodes.bad_machine.system.build.toplevel;
          unused = nodes.unused_machine.system.build.toplevel;
        in
        # python
        ''
          ${testScriptPreamble}

          orig = "${orig}"
          bad = "${bad}"
          unused = "${unused}"

          machine.start(allow_reboot=True)

          # Ensure we booted using an entry with counters enabled
          machine.succeed(
              "test -e /sys/firmware/efi/efivars/LoaderBootCountPath-4a67b082-0a4c-41cf-b6c7-440b29bb8c4f"
          )

          # systemd-bless-boot should have already removed the "+2" suffix from the boot entry
          machine.wait_for_unit("systemd-bless-boot.service")
          conf_file = check_generation(1)
          check_current_system(orig)

          print(machine.succeed("cat /boot/loader/entries/*.conf"))

          # Register the bad configuration as generation 2 and another good
          # configuration as generation 3, then make generation 2 the default.
          # This verifies that `preferred` in loader.conf selects gen 2 even
          # though gen 3 sorts higher, and that once gen 2 is marked bad we
          # fall back to the newest non-bad entry (gen 3).
          machine.succeed("nix-env -p /nix/var/nix/profiles/system --set ${bad}")
          machine.succeed("nix-env -p /nix/var/nix/profiles/system --set ${unused}")
          machine.succeed(f"{bad}/bin/switch-to-configuration boot")

          # Ensure new bootloader entries have initialized counters
          check_generation(1)
          check_generation(2, 2)
          check_generation(3, 2)

          machine.reboot()

          machine.wait_for_unit("multi-user.target")
          check_current_system(bad)
          check_generation(1)
          check_generation(2, 1, 1)
          check_generation(3, 2)

          machine.reboot()

          machine.wait_for_unit("multi-user.target")
          check_current_system(bad)
          check_generation(1)
          check_generation(2, 0, 2)
          check_generation(3, 2)

          machine.reboot()

          machine.wait_for_unit("multi-user.target")
          # Gen 2 has exhausted its tries; `preferred` skips it and `default
          # nixos-*` resolves to the newest non-bad entry, which is gen 3.
          check_current_system(unused)
          machine.wait_for_unit("systemd-bless-boot.service")
          check_generation(2, 0, 2)
          check_generation(3)
        '';
    };

  bootCountingSpecialisation =
    let
      baseConfig = {
        imports = [ common ];
        boot.loader.systemd-boot.bootCounting = {
          enable = true;
          tries = 2;
        };
      };

      specialisationName = "+something+-+that+-+breaks-parsing+-+";
    in
    runTest {
      name = "systemd-boot-counting-specialisation";
      meta.maintainers = with lib.maintainers; [ julienmalka ];

      nodes = {
        machine =
          { nodes, lib, ... }:
          {
            imports = [ baseConfig ];
            specialisation.${specialisationName}.configuration = {
              boot.loader.systemd-boot.sortKey = "something";
            };
          };
      };
      testScript =
        { nodes, ... }:
        let
          orig = nodes.machine.system.build.toplevel;
        in
        # python
        ''
          ${testScriptPreamble}

          orig = "${orig}"

          # Ensure we booted using an entry with counters enabled
          machine.succeed(
              "test -e /sys/firmware/efi/efivars/LoaderBootCountPath-4a67b082-0a4c-41cf-b6c7-440b29bb8c4f"
          )

          # systemd-bless-boot should have already removed the "+2" suffix from the boot entry
          machine.wait_for_unit("systemd-bless-boot.service")
          check_generation(1)
          check_current_system(orig)

          # Ensure the bootloader entry for the specialisation has initialized the boot counter
          check_generation(1, 2, specialisation="${specialisationName}")
        '';
    };

  defaultEntryWithBootCounting = defaultEntry { withBootCounting = true; };

  garbageCollectEntryWithBootCounting = garbage-collect-entry { withBootCounting = true; };
}